ci(react): install Playwright in the YAML file #1450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lipata
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds Playwright browser installation steps to CI/CD pipelines and updates test setup configuration. The changes ensure that Playwright browsers are available before running tests in both GitHub Actions and Azure Pipelines workflows.
Key Changes:
- Added Playwright chromium-headless-shell installation step in CI workflows
- Updated test setup to use
globalThisinstead ofglobaland removed unused import - Set
CIenvironment variable for test execution
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| setupTests.ts | Updated to use globalThis instead of global and removed unused testing library import |
| node.js.yml | Added Playwright browser installation step and CI environment variable for GitHub Actions |
| azure-pipelines.yml | Added Playwright browser installation step and CI environment variable for Azure Pipelines |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/cli/templates/react/igr-ts/projects/_base/files/__dot__github/workflows/node.js.yml
Outdated
Show resolved
Hide resolved
packages/cli/templates/react/igr-ts/projects/_base/files/__dot__azure/azure-pipelines.yml
Show resolved
Hide resolved
…__github/workflows/node.js.yml Co-authored-by: Copilot <[email protected]>
…__azure/azure-pipelines.yml Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/cli/templates/react/igr-ts/projects/_base/files/src/setupTests.ts
Show resolved
Hide resolved
Lipata
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.